From 3990898b5e3157a94f23fc4bb11744f7ff5e7092 Mon Sep 17 00:00:00 2001 From: Stefan Hajnoczi Date: Sat, 1 Aug 2015 08:39:31 -0400 Subject: [PATCH 5/7] rtl8139: check IP Total Length field (CVE-2015-5165) RH-Author: Stefan Hajnoczi Message-id: <1438418373-7324-6-git-send-email-stefanha@redhat.com> Patchwork-id: 67262 O-Subject: [virt-devel] [RHEL-6.7.z qemu-kvm EMBARGOED PATCH 5/7] rtl8139: check IP Total Length field (CVE-2015-5165) Bugzilla: 1248761 RH-Acked-by: Dr. David Alan Gilbert RH-Acked-by: Xiao Wang RH-Acked-by: Laszlo Ersek The IP Total Length field includes the IP header and data. Make sure it is valid and does not exceed the Ethernet payload size. Signed-off-by: Stefan Hajnoczi Signed-off-by: Jeff E. Nelson --- hw/rtl8139.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index e3f0d3c..798dcab 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -2185,7 +2185,12 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) } ip_protocol = ip->ip_p; - ip_data_len = be16_to_cpu(ip->ip_len) - hlen; + + ip_data_len = be16_to_cpu(ip->ip_len); + if (ip_data_len < hlen || ip_data_len > eth_payload_len) { + goto skip_offload; + } + ip_data_len -= hlen; if (txdw0 & CP_TX_IPCS) { -- 2.1.0