From bbd4931e233557c34ec216ed4784282a16b4f3e4 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Wed, 31 May 2017 11:15:12 +0200 Subject: [PATCH 05/13] qemu-iotests: Test streaming with missing job ID RH-Author: Kevin Wolf Message-id: <1496229312-8649-3-git-send-email-kwolf@redhat.com> Patchwork-id: 75444 O-Subject: [RHEL-7.4 qemu-kvm-rhev PATCH 2/2] qemu-iotests: Test streaming with missing job ID Bugzilla: 1456424 RH-Acked-by: Fam Zheng RH-Acked-by: Jeffrey Cody RH-Acked-by: Max Reitz RH-Acked-by: John Snow This adds a small test for the image streaming error path for failing block_job_create(), which would have found the null pointer dereference in commit a170a91f. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Kashyap Chamarthy Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody (cherry picked from commit 0bb0aea4bac2332389a9b481f650a2a9df80ea0c) Signed-off-by: Miroslav Rezanina --- tests/qemu-iotests/030 | 4 ++++ tests/qemu-iotests/030.out | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 0d472d5..e59bee2 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030 @@ -147,6 +147,10 @@ class TestSingleDrive(iotests.QMPTestCase): result = self.vm.qmp('block-stream', device='nonexistent') self.assert_qmp(result, 'error/class', 'GenericError') + def test_job_id_missing(self): + result = self.vm.qmp('block-stream', device='mid') + self.assert_qmp(result, 'error/class', 'GenericError') + class TestParallelOps(iotests.QMPTestCase): num_ops = 4 # Number of parallel block-stream operations diff --git a/tests/qemu-iotests/030.out b/tests/qemu-iotests/030.out index 84bfd63..391c857 100644 --- a/tests/qemu-iotests/030.out +++ b/tests/qemu-iotests/030.out @@ -1,5 +1,5 @@ -...................... +....................... ---------------------------------------------------------------------- -Ran 22 tests +Ran 23 tests OK -- 1.8.3.1